Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate RGBA=R|G|B|A helper constant for ColorComponentFlags #537

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Generate RGBA=R|G|B|A helper constant for ColorComponentFlags #537

merged 1 commit into from
Dec 28, 2021

Conversation

MarijnS95
Copy link
Collaborator

Fixes #536

When the misleading all() function was removed in #478 it also made all color components for ColorComponentFlags significantly more verbose to write, see #536.

@MarijnS95
Copy link
Collaborator Author

Not sure if this is the "right" way, perhaps it's cleaner to throw this as a manual impl in src/vk/prelude.rs. Keeps generator edgecases on a low, too.

@MarijnS95 MarijnS95 force-pushed the colorcomponentflags-rgba branch from 1d70447 to 2264ad4 Compare December 28, 2021 18:22
@Ralith
Copy link
Collaborator

Ralith commented Dec 28, 2021

I'd lean towards handwriting this. Happy to have it otherwise, though!

@MarijnS95
Generate RGBA=R|G|B|A helper constant for ColorComponentFlags
e9635c8 
When the misleading `all()` function was removed in #478 it also made
all color components for `ColorComponentFlags` significantly more
verbose to write, see #536.
@MarijnS95 MarijnS95 force-pushed the colorcomponentflags-rgba branch from 2264ad4 to e9635c8 Compare December 28, 2021 18:42
@MarijnS95 MarijnS95 requested a review from Ralith December 28, 2021 18:42
@MarijnS95
Copy link
Collaborator Author

Much cleaner and simpler indeed :)

@expenses
Copy link

Looks great! 💖

@Ralith Ralith merged commit 8a46a15 into master Dec 28, 2021
@Ralith Ralith deleted the colorcomponentflags-rgba branch December 28, 2021 19:52
MarijnS95 added a commit that referenced this pull request Jan 3, 2022
@MarijnS95
changelog: Add entries for recent PRs #533, #537, #542
60c3e65
Ralith pushed a commit that referenced this pull request Jan 3, 2022
@MarijnS95 @Ralith
changelog: Add entries for recent PRs #533, #537, #542
7626667
@MarijnS95 MarijnS95 mentioned this pull request Jan 9, 2022
Merged
@MarijnS95 MarijnS95 mentioned this pull request Jan 19, 2022
Merged
MarijnS95 added a commit that referenced this pull request Jan 22, 2022
@MarijnS95
ci: Build-test documentation with warnings disallowed, and fix links
d47f6c6 
Broken links that snuck in (most recently in #530 and #537) while the
CI was not testing the documentation have also been corrected, to allow
it to succeed again (and to have proper docs in the first place).
Ralith pushed a commit that referenced this pull request Jan 22, 2022
@MarijnS95
ci: Build-test documentation with warnings disallowed, and fix links (#…
315f1f0 
…559)

Broken links that snuck in (most recently in #530 and #537) while the
CI was not testing the documentation have also been corrected, to allow
it to succeed again (and to have proper docs in the first place).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helper function for rgba vk::ColorComponentFlags
3 participants
@MarijnS95 @Ralith @expenses