Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/khr: Drop _khr suffix from get_memory_fd_properties_khr #580

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

MarijnS95
Copy link
Collaborator

This is an erroneous suffix that's already captured in the module path of this item, and should be omitted everywhere. This method is the only offender besides the experimental AMD extensions.

Fixes: 98def0a ("Add VK_KHR_external_memory_fd extension support (#270)")


Draft because I want to shelve this for a bit until the next breaking release... We can probably get all the current extension additions and Vulkan 1.3 API out the door with a simple patch bump.

This is an erroneous suffix that's already captured in the module path
of this item, and should be omitted everywhere.  This method is the only
offender besides the experimental AMD extensions.

Fixes: 98def0a ("Add `VK_KHR_external_memory_fd` extension support (#270)")
@MarijnS95 MarijnS95 marked this pull request as ready for review February 19, 2022 00:16
@MarijnS95 MarijnS95 merged commit d6cb64d into master Feb 19, 2022
@MarijnS95 MarijnS95 deleted the drop-khr-suffix branch February 19, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants