Set MSRV through rust-version in Cargo.toml and validate in CI
#604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ash-rs#590] introduced an unsuspecting MSRV bump. While we're pro-ba-bly fine having these at the benefit of better code (in this case more appropriate `const` annotations), they should at least be clear to us when merging through a CI failure (or up-front bump of this version in the CI script). At the same time setting [`rust-version` in `Cargo.toml`] provides a more helpful "requires newer rustc" error message (since Rust 1.56.0) instead of showing potentially tons of irrelevant compile errors in this crate to the user. [ash-rs#590]: ash-rs#590 [`rust-version` in `Cargo.toml`]: https://doc.rust-lang.org/cargo/reference/manifest.html?highlight=pack#the-rust-version-field
Ralith
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#590 introduced an unsuspecting MSRV bump. While we're pro-ba-bly fine having these at the benefit of better code (in this case more appropriate
constannotations), they should at least be clear to us when merging through a CI failure (or up-front bump of this version in the CI script). At the same time settingrust-versioninCargo.tomlprovides a more helpful "requires newer rustc" error message (since Rust 1.56.0) instead of showing potentially tons of irrelevant compile errors in this crate to the user.