Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Default impls and trivial instance/device wrapper methods #606

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Mar 29, 2022

I did not inline load, any of the wrappers that invoke read_into_*_vector helpers, or (for now) extensions methods. In theory this should be a nice clean overhead reduction at runtime. Data on buildtime impact would be great!

@MarijnS95
Copy link
Collaborator

So it seems my random yet completely unrepresentative workstation machine is now used for benchmarking 😂

Before:

$ hyperfine -p 'cargo clean -p ash' 'cargo b -p ash'
Benchmark 1: cargo b -p ash
  Time (mean ± σ):      5.841 s ±  0.031 s    [User: 6.671 s, System: 0.373 s]
  Range (min … max):    5.786 s …  5.898 s    10 runs

After:

$ hyperfine -p 'cargo clean -p ash' 'cargo b -p ash'
Benchmark 1: cargo b -p ash
  Time (mean ± σ):      5.724 s ±  0.026 s    [User: 6.435 s, System: 0.364 s]
  Range (min … max):    5.691 s …  5.782 s    10 runs

~120ms.

@Ralith
Copy link
Collaborator Author

Ralith commented Mar 29, 2022

Looks like a slight win on my end too. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants