Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/ext: Add VK_EXT_mesh_shader #654

Closed
wants to merge 3 commits into from
Closed

extensions/ext: Add VK_EXT_mesh_shader #654

wants to merge 3 commits into from

Conversation

BeastLe9enD
Copy link
Contributor

Today the cross vendor mesh shader extension came out. I added support for the extension to ash

@MarijnS95
Copy link
Collaborator

We typically approach this by first updating the generated code in a distinct PR (done in #655), followed by separately PR'ing individual extension wrappers.

If you can rebase this once #655 is in the PR title becomes representative of the contents again, and we can review+merge this too :)

@MarijnS95 MarijnS95 changed the title Add support for VK_EXT_mesh_shader extensions/ext: Add VK_EXT_mesh_shader Sep 5, 2022
Comment on lines +6 to +7
#[derive(Clone)]
pub struct MeshShader {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since recently we also link this struct to the extension docs:

Suggested change
#[derive(Clone)]
pub struct MeshShader {
/// <https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_mesh_shader.html>
#[derive(Clone)]
pub struct MeshShader {

@BeastLe9enD
Copy link
Contributor Author

@MarijnS95 yea sure! I'll do once the other PR is merged!

@@ -268,6 +268,7 @@ cargo run --bin texture
### Utility libraries
* [vk-sync](https://github.com/gwihlidal/vk-sync-rs) - Simplified Vulkan synchronization logic, written in rust.
* [vk-mem-rs](https://github.com/gwihlidal/vk-mem-rs) - This crate provides an FFI layer and idiomatic rust wrappers for the excellent AMD Vulkan Memory Allocator (VMA) C/C++ library.
* [vk-mem-alloc-rs](https://github.com/projectkml/vk-mem-alloc-rs) - A very lightweight wrapper around the AMD Vulkan Memory Allocator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this is relevant to the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made another PR with this and I accidently selected the wrong branch, but I removed it so its not added!

@ProjectKML ProjectKML closed this by deleting the head repository Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants