Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_std support #664

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Add no_std support #664

merged 8 commits into from
Mar 25, 2024

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Sep 25, 2022 •
edited
Loading

no_std support is enabled by disabling the default std feature.

@i509VCB i509VCB force-pushed the no_std branch 5 times, most recently from 7da239b to 6212734 Compare September 25, 2022 20:51
@MarijnS95 MarijnS95 changed the title Add no_std support Add no_std support Sep 25, 2022
MarijnS95
MarijnS95 requested changes Sep 25, 2022
View reviewed changes
Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be in early stages, I'll mark this as WIP until you deem it ready to review; here are a few basal points I started writing on while realizing that.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ash-window/Cargo.toml Outdated Show resolved Hide resolved
ash/Cargo.toml Outdated Show resolved Hide resolved
ash/src/device.rs Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 marked this pull request as draft September 25, 2022 22:25
@MarijnS95
Copy link
Collaborator

@i509VCB is this still something you want to pursue?

@i509VCB
Copy link
Contributor Author

i509VCB commented Nov 24, 2022

Yes I plan to work on this, just have been doing other things the last month

@i509VCB i509VCB force-pushed the no_std branch 3 times, most recently from ac70e41 to 3e161b7 Compare November 24, 2022 04:04
i509VCB
i509VCB commented Nov 24, 2022
View reviewed changes
ash/src/lib.rs Outdated Show resolved Hide resolved
@i509VCB i509VCB marked this pull request as ready for review November 24, 2022 04:09
@i509VCB
Copy link
Contributor Author

i509VCB commented Nov 24, 2022

other than the issue with ash-window, the rest of the pull request is ready.

MarijnS95
MarijnS95 requested changes Nov 30, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
ash-window/Cargo.toml Outdated Show resolved Hide resolved
ash/Cargo.toml Outdated Show resolved Hide resolved
ash/src/device.rs Outdated Show resolved Hide resolved
ash/src/prelude_internal.rs Outdated Show resolved Hide resolved
ash/src/instance.rs Outdated Show resolved Hide resolved
ash/src/lib.rs Outdated Show resolved Hide resolved
ash/src/lib.rs Outdated Show resolved Hide resolved
ash/src/util.rs Outdated Show resolved Hide resolved
@i509VCB i509VCB force-pushed the no_std branch 5 times, most recently from 1aa975e to 5b3c4e4 Compare December 20, 2022 20:49
@nical
Copy link

nical commented Dec 21, 2022

Note that Gecko is currently at rustc 1.63 let's please wait until Gecko updates to 1.64 before raising the msrv. Gecko tends to lag behind the latest stable a bit but usually not too much, so it shouldn't be long.

@MarijnS95
Copy link
Collaborator

@nical Ash won't blindly bump its MSRV, at least not in regular patch releases.

@nical
Copy link

nical commented Dec 21, 2022 •
edited
Loading

Sorry, I got confused, I though I was on the wgpu repo. That said, bumping the msrv will prevent wgpu from updating ash until gecko catches up.
It would be great if a version containing #695 would be published before an msrv bump.

@MarijnS95
Copy link
Collaborator

It would be great if a version containing #695 would be published before an msrv bump.

Again, non-breaking releases with bugfixes and improvements won't include an MSRV bump (that makes them... breaking...). That said, I'd like to be requested new releases explicitly, otherwise they might sit for a while.

@i509VCB
Copy link
Contributor Author

i509VCB commented Dec 21, 2022

Note that Gecko is currently at rustc 1.63 let's please wait until Gecko updates to 1.64 before raising the msrv. Gecko tends to lag behind the latest stable a bit but usually not too much, so it shouldn't be long.

The MSRV bump here only applies if the std feature is disabled. So ash effectively has an std MSRV and an alloc MSRV

@MarijnS95
Copy link
Collaborator

@nical fwiw #695 was published in https://github.com/ash-rs/ash/releases/tag/0.37.2.

@nical
Copy link

nical commented Jan 11, 2023

Thanks a lot!

@MarijnS95
Copy link
Collaborator

MarijnS95 commented Oct 9, 2023 •
edited
Loading

@nical it looks like wgpu meanwhile has an MSRV of 1.65 (https://github.com/gfx-rs/wgpu#msrv-policy), and we should be well okay bumping to or past 1.64 IMHO (that's older than half a year - even though we didn't document our policy explicitly yet).

@i509VCB is it time to revive this on 1.64, and drop all the workarounds for older MSRV?

@nical
Copy link

nical commented Oct 9, 2023

Yes, thanks a lot for being mindful of wgpu's constraints!

@i509VCB
Copy link
Contributor Author

i509VCB commented Oct 9, 2023

@nical it looks like wgpu meanwhile has an MSRV of 1.65 (https://github.com/gfx-rs/wgpu#msrv-policy), and we should be well okay bumping to or past 1.64 IMHO (that's older than half a year - even though we didn't document our policy explicitly yet).

@i509VCB is it time to revive this on 1.64, and drop all the workarounds for older MSRV?

Yeah I can reapply the changes into 1.64, just not going to be today.

@i509VCB
Add no_std support
215578b 
Also includes an explicit change to the Cargo.toml to raise the MSRV to 1.69, which ash already requires.
@i509VCB
Copy link
Contributor Author

i509VCB commented Dec 9, 2023

@MarijnS95 I have rebuilt the pull request. Ash appears to have raised it's MSRV to 1.69 already, so I went with that.

MarijnS95
MarijnS95 reviewed Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any clue when unnecessary_qualifications broke?

ash/src/extensions/amd/shader_info.rs Outdated Show resolved Hide resolved
ash/src/extensions/nv/ray_tracing.rs Outdated Show resolved Hide resolved
ash/src/entry.rs Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 requested a review from Ralith March 24, 2024 17:23
Ralith
Ralith approved these changes Mar 24, 2024
View reviewed changes
ash/src/lib.rs Outdated Show resolved Hide resolved
ash/src/lib.rs Outdated Show resolved Hide resolved
MarijnS95
MarijnS95 reviewed Mar 24, 2024
View reviewed changes
ash/src/entry.rs Outdated Show resolved Hide resolved
ash/src/lib.rs Outdated Show resolved Hide resolved
ash/src/lib.rs Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 force-pushed the no_std branch 2 times, most recently from 3bcfcfe to 3fb62c0 Compare March 24, 2024 20:49
@MarijnS95 MarijnS95 merged commit 9f712c5 into ash-rs:master Mar 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@msiglreith msiglreith msiglreith left review comments

@MarijnS95 MarijnS95 MarijnS95 approved these changes

Assignees
No one assigned
Labels
Blocking a release MSRV bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@i509VCB @MarijnS95 @nical @Ralith @msiglreith