Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/khr: Add VK_KHR_performance_query #726

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 mentioned this pull request Mar 28, 2023
55 tasks
@wolfiestyle
Copy link

Couldn't test locally. patch doesn't work applied to 0.37.2, and trying to use HEAD w/patch breaks other deps.
The error:

$ cargo check
    Checking ash v0.37.2+1.3.238 (/home/wolfie/progs/rust/vktest/ash/ash)
error[E0599]: no associated item named `NAME` found for struct `KhrPerformanceQueryFn` in the current scope
    --> ash/ash/src/extensions/khr/performance_query.rs:107:64
     |
107  |     pub const NAME: &'static CStr = vk::KhrPerformanceQueryFn::NAME;
     |                                                                ^^^^ associated item not found in `KhrPerformanceQueryFn`
     |
    ::: ash/ash/src/vk/extensions.rs:7017:1
     |
7017 | pub struct KhrPerformanceQueryFn {
     | -------------------------------- associated item `NAME` not found for this struct

@MarijnS95
Copy link
Collaborator Author

@wolfiestyle I'll address that after merging and backporting this to the 0.37-stable branch, and for the time being you can replace this associated constant with:

    #[inline]
    pub const fn name() -> &'static CStr {
        vk::KhrPerformanceQueryFn::name()
    }

@MarijnS95 MarijnS95 force-pushed the khr-performance-query branch from f8a9304 to 7aaf333 Compare March 29, 2023 22:48
@MarijnS95 MarijnS95 force-pushed the khr-performance-query branch from 7aaf333 to 1ed900b Compare March 30, 2023 09:16
@MarijnS95 MarijnS95 merged commit 74f68f2 into master Apr 3, 2023
@MarijnS95 MarijnS95 deleted the khr-performance-query branch April 3, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants