extensions: Remove get_properties() helper from extension wrappers
#728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
extensions-remove-get_properties
branch
from
0a47cbb to
a5d6aa3
Compare
This helper function isn't consistently implemented across most extension wrappers, and promotes bad Vulkan patterns by not making it obvious to the caller that `get_physical_device_properties2()` can and should be used to fill multiple properties structs at once.
MarijnS95
force-pushed
the
extensions-remove-get_properties
branch
from
a5d6aa3 to
1728f13
Compare
Ralith
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper function isn't consistently implemented across most extension wrappers, and promotes bad Vulkan patterns by not making it obvious to the caller that
get_physical_device_properties2()can and should be used to fill multiple properties structs at once.