generator: Apply must_use
attributes to all Vulkan structs
#845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All structs are marked as
Copy
, and builders moveself
for a convenient builder pattern directly ondefault()
(using&mut
requires first keeping the instance alive in alet
binding). This however leads to builder functions accidentally moving a copy ofself
, mutating it, and dropping the result directly when the caller did not consume the returned value in ad-hoc field updates, in turn leaving the author confused why their code compiles without warnings while the struct was not updated.Annotating all Vulkan structs with
#[must_use]
should at least give them an idea why, especially because of Rust allowing us to set a custom message.