Inline predule module contents into their parent modules
#972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Dec 7, 2024
MarijnS95
force-pushed
the
rm-prelude
branch
3 times, most recently
from
4f41c00 to
96eeda9
Compare
Ralith
reviewed
Dec 7, 2024
We've never used `prelude` in a sensible way, both modules inside the crate root and `vk` namespace have always abused these modules to store a random combination of private utilities next to a few extra hand-written type/trait definitions and implementations. Neither of these need to glob-imported by users to make easy use of `ash` functionality besides perhaps ensuring traits like `Handle` and `TaggedStructure` are in scope. Their glob imports were only useful to `ash` itself, and even then the `vk::prelude` was already fully glob-reexported in `vk`. Besides inlining its contents, I've shuffled some private helpers like `debug_flags()` closer to where they are being used.
Ralith
approved these changes
Dec 8, 2024
Any time 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've never used
preludein a sensible way, both modules inside the crate root andvknamespace have always abused these modules to store a random combination of private utilities next to a few extra hand-written type/trait definitions and implementations, as outlined before in #879 (comment).Neither of these need to glob-imported by users to make easy use of
ashfunctionality besides perhaps ensuring traits likeHandleandTaggedStructureare in scope. Their glob imports were only useful toashitself, and even then thevk::preludewas already fully glob-reexported invk.Besides inlining its contents, I've shuffled some private helpers like
debug_flags()closer to where they are being used.