Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assetpath.cs): retarget PATH_PROJECT #80

Conversation

TNThomas
Copy link
Contributor

retarget PATH_PROJECT to "Assets/com.fluid.behavior-tree"

fix #79

retarget PATH_PROJECT to "Assets/com.fluid.behavior-tree"

fix ashblue#79
@ashblue
Copy link
Owner

ashblue commented Jan 16, 2023

This looks great. I'll boot up the CI

@ashblue
Copy link
Owner

ashblue commented Jan 16, 2023

Test suite looking good (I really need to automate the Unity suite running with https://game.ci/)
image

@ashblue
Copy link
Owner

ashblue commented Jan 16, 2023

The test seems to be stuck which verifies everything still builds okay. I think you need to adjust these two lines here in .github/workflows/workflow.yml.

            - uses: actions/checkout@v2
            - uses: actions/setup-node@v2

Changing them to this should fix it.

            - uses: actions/checkout@v3
            - uses: actions/setup-node@v3

I think they may have deprecated the V2 versions.

@ashblue
Copy link
Owner

ashblue commented Jan 16, 2023

Actually scrap the above, it's missing the proper run on hooks. Looks like when optimizing the CI runs I messed up some things. I'll get this adjusted long term in my package generator ashblue/oyster-package-generator#66

name: CI
on:
    push:
        branches:
            - master
    pull_request:
        branches:
            - develop
            - master
jobs:
    test:
        runs-on: ubuntu-latest
        steps:
            - uses: actions/checkout@v3
            - uses: actions/setup-node@v3
              with:
                  node-version: '14'
            - run: npm install
            - run: npm run build
            - name: Release
              env:
                  NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
                  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
              run: npm run semantic-release

You should be able to git commit --amend this code into the existing commit.

…mver-regex-3.1.4

chore(deps): bump semver-regex from 3.1.3 to 3.1.4
Copy link
Owner

@ashblue ashblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@ashblue ashblue merged commit 7078ec0 into ashblue:develop Jan 17, 2023
github-actions bot pushed a commit that referenced this pull request Jan 17, 2023
…Path-points-nowhere

fix(assetpath.cs): retarget PATH_PROJECT
@ashblue
Copy link
Owner

ashblue commented Jan 17, 2023

@all-contributors please add @TNThomas for 💻 🚧

@allcontributors
Copy link
Contributor

@ashblue

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@ashblue
Copy link
Owner

ashblue commented Jan 17, 2023

https://github.com/all-contributors please add @TNThomas for bug and code

@ashblue
Copy link
Owner

ashblue commented Jan 17, 2023

@all-contributors please add @TNThomas for bug and code

@allcontributors
Copy link
Contributor

@ashblue

I've put up a pull request to add @TNThomas! 🎉

@ashblue
Copy link
Owner

ashblue commented Nov 9, 2024

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PATH_PROJECT in AssetPath describes a folder that never exists
2 participants