-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent mixing profiles #207
base: develop
Are you sure you want to change the base?
Conversation
prevent mixing of aws profiles Without this change, the regexp search for the next available token, but don't take profile boundaries (starting with [ ) into consideration. Assuming target profile is [default] but the [default] profile don't have an aws_session_token, the procedure would take aws_access_key_id is taken from profile [default] but the the aws_session_token from any other profile which leads to an authorization error
Thanks for the PR. Could you provide an example of a file that triggered the bug? Lines 182 to 213 in ece4389
|
Sure. The following credentials file would result in taking aws_session_token from profile "dev2" and the aws_access_key_id from "default" for the profile "default" `[default] [dev1] [dev2] |
I will check to create a test, but not that experienced in this. May take a while. |
4e730df
to
cbc4901
Compare
prevent mixing of aws profiles
Without this change, the regexp search for the next available token, but don't take profile boundaries (starting with [ ) into consideration.
Assuming target profile is [default] but the [default] profile don't have an aws_session_token, the procedure would take aws_access_key_id is taken from profile [default] but the the aws_session_token from any other profile which leads to an authorization error