Upgrade to support ng 19 #96
Open
+9,804
−6,616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chibuzor27
commented
Dec 10, 2024
Chibuzor27
commented
- Update package version
- Update demo app to angular version 19
- Update directives and component to standalone
- Move declarations to import in Paystack module
- Update 'ngClass' and 'ngStyle' to 'class' and 'style' respectively in Paystack component
- Fix no-reflecting class attribute on directive
- Fix typo in error message in Paystack service
- Add style for Paystack buttons in demo app
ashinzekene
requested changes
Dec 11, 2024
| @@ -10,7 +10,8 @@ declare var window: Partial<MyWindow>; | |||
| @Component({ | |||
| selector: 'angular4-paystack-embed', | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| template: `<div id="paystackEmbedContainer"></div>` | |||
| template: `<div id="paystackEmbedContainer"></div>`, | |||
| standalone: true | |||
There was a problem hiding this comment.
The library support angular from v8-17 (now 19). This would cause older projects to break
There was a problem hiding this comment.
I've tested changes with angular 16 and 17, and it seems to work pretty well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.