Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower.json not being updated #37

Merged
merged 2 commits into from
Oct 4, 2017
Merged

bower.json not being updated #37

merged 2 commits into from
Oct 4, 2017

Conversation

joaquinjsb
Copy link
Contributor

@joaquinjsb joaquinjsb commented Sep 5, 2017

also on the 2.1.0 release there's no dist folder so is creating conflicts with bower, to solve this I'm using an override of the main, but i have to update the min.js so I can use the threshold feature.

also on the 2.1.0 release  there's no dist folder.
@ashish-chopra
Copy link
Owner

Hi @joaquinjsb

Is that the only change needed to make it available using bower?

Also, is there any other way to make library available for bower without committing dist folder?

Cheers
Ashish

@joaquinjsb
Copy link
Contributor Author

joaquinjsb commented Sep 28, 2017

Hi @ashish-chopra,
you already registered the package within bower so you just need to create a new release and bower will do the rest.

you have then to modify your bower.json tu point the main to your src instead of the dist file,
"main": "dist/angularjs-gauge.js",

I have done the new modification

no need for override / dist folder.
@ashish-chopra ashish-chopra merged commit a2af58c into ashish-chopra:master Oct 4, 2017
@joaquinjsb joaquinjsb deleted the patch-1 branch January 15, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants