Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _convert_=partial from trainer instantiation #301

Merged
merged 1 commit into from
May 17, 2022

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented May 17, 2022

_convert_=partial in trainer instantiation was needed to ensure the weight averaging flag doesn't crash the run.

The flag has been deprecated so it can be removed now.

@ashleve ashleve changed the title Remove _convert_=partial from trainer instantiation Remove _convert_="partial" from trainer instantiation May 17, 2022
@ashleve ashleve changed the title Remove _convert_="partial" from trainer instantiation Remove _convert_=partial from trainer instantiation May 17, 2022
@ashleve ashleve merged commit 4a66daa into release/1.4 May 17, 2022
@ashleve ashleve deleted the remove-convert-partial branch May 17, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant