Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with Jekyll 4.2 #38

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Conversation

fauno
Copy link
Contributor

@fauno fauno commented Dec 29, 2020

@source_dir is new to jekyll 4.2 and made the build fail when trying to debug output in Jekyll::DataReader#read_data_file. I also found that the initialize code is the same so I changed it to use super, not sure if you wanted to keep it that way, I can rollback those changes.

tests pass but 4 are failing because rouge is adding a language class to the output and is different from the fixture. I can fix that too.

Closes #39

@ashmaroli
Copy link
Owner

Thank you for submitting this PR, @fauno.
Regarding the changes, I prefer having a bare super call instead of super(site).. and RuboCop has detected an offense as well.


Note to self: Migrate CI from Travis to GH Actions before merging this..

@fauno
Copy link
Contributor Author

fauno commented Dec 29, 2020 via email

@ashmaroli ashmaroli changed the title compatibility with jekyll 4.2 Fix incompatibility with Jekyll 4.2 Jan 15, 2021
@ashmaroli
Copy link
Owner

Thanks @fauno

@ashmaroli ashmaroli merged commit 13a5a67 into ashmaroli:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize source_dir in ThemeDataReader
2 participants