Merge pull request microsoft#85 from rajkumar42/dev/janraj/telemetry

Adding telemetry for Engine.
asialasr · Oct 7, 2015 · 83525d5 · 83525d5
2 parents 71d7f69 + 59193e2
commit 83525d5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/src/AndroidDebugLauncher/Launcher.cs b/src/AndroidDebugLauncher/Launcher.cs
@@ -113,7 +113,7 @@ void IPlatformAppLauncher.SetupForDebugging(out LaunchOptions result)
 
                     if (launchErrorTelemetryResult != null)
                     {
-                        Telemetry.SendLaunchError(launchErrorTelemetryResult);
+                        Telemetry.SendLaunchError(launchErrorTelemetryResult, _targetEngine.ToString());
                     }
                 }
             );

diff --git a/src/AndroidDebugLauncher/Telemetry.cs b/src/AndroidDebugLauncher/Telemetry.cs
@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+using MICore;
 using Microsoft.Internal.VisualStudio.Shell;
 using Microsoft.Internal.VisualStudio.Shell.Interop;
 using Microsoft.VisualStudio.Shell;
@@ -21,6 +22,7 @@ internal static class Telemetry
 
         private const string Event_LaunchError = @"VS/Diagnostics/Debugger/Android/LaunchFailure";
         private const string Property_LaunchErrorResult = @"VS.Diagnostics.Debugger.Android.FailureResult";
+        private const string Property_LaunchTargetEngine = @"VS.Diagnostics.Debugger.Android.TargetEngine";
 
         #region LaunchFailure support
 
@@ -101,9 +103,11 @@ public static string GetLaunchErrorResultValue(Exception exception)
                 return exception.GetType().FullName;
             }
         }
-        public static void SendLaunchError(string launchErrorTelemetryResult)
+        public static void SendLaunchError(string launchErrorTelemetryResult, string targetEngine)
         {
-            SendEvent(Event_LaunchError, new KeyValuePair<string, object>(Property_LaunchErrorResult, launchErrorTelemetryResult));
+            SendEvent(Event_LaunchError, 
+                new KeyValuePair<string, object>(Property_LaunchErrorResult, launchErrorTelemetryResult),
+                new KeyValuePair<string, object>(Property_LaunchTargetEngine, targetEngine));
         }
 
         #endregion

diff --git a/src/MICore/LaunchOptions.cs b/src/MICore/LaunchOptions.cs
@@ -29,8 +29,9 @@ public enum TargetArchitecture
 
     public enum TargetEngine
     {
+        Unknown,
         Native,
-        Java
+        Java,
     }
 
     public enum LaunchCompleteCommand