Contact Us v1 #1
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ericgrigorian The double quotes are done because it was more consistent with Main app however we can decide and I can run the linter again later. |
| @@ -0,0 +1,34 @@ | |||
| import { useState } from "react"; | |||
| import { FieldValues } from "react-hook-form"; | |||
There was a problem hiding this comment.
Typings from abstracted libraries should be avoided in most cases. Consider if this is the case because this type is very wide. Using FieldValues from Blocks narrows the FieldValues, but maybe more than you would like. Since it is being used in the submit handler, perhaps the interface for the form default values is a better choice? Your call, just something to think about.
| import '@fontsource/roboto/700.css'; | ||
| import { createTheme, ThemeProvider } from '../../components/dist'; | ||
| import React from "react"; | ||
| import { CssBaseline } from "@mui/material"; |
There was a problem hiding this comment.
Blocks also provides a CssBaseline and should be favored. However, it may collide with underlying MUI typings. If that is the case, we should get a ticket in the Blocks backlog to address it through either me or Colin
There was a problem hiding this comment.
This is exceptionally well done and organized. I left some notes on things to consider for future stuff, and the only requested change here is to remove the Roboto font. In the main CMS app, the font will be there, and the Blocks theme will expect it by default. Otherwise, good job on a short schedule!
| import { createTheme, ThemeProvider } from '../../components/dist'; | ||
| import React from "react"; | ||
| import { CssBaseline } from "@mui/material"; | ||
| import "@fontsource/roboto/300.css"; |
There was a problem hiding this comment.
We shouldn't need this. Asics fonts should be used instead. Not sure if Colin added them to the Blocks package, but if not, we should add them and use those.
|
|
||
| const theme = createTheme({ | ||
| typography: { | ||
| fontFamily: '"Roboto", "Helvetica", Helvetica, Arial, sans-serif' | ||
| } | ||
| fontFamily: '"Roboto", "Helvetica", Helvetica, Arial, sans-serif', |
There was a problem hiding this comment.
This can be removed in favor of the default Asics fonts
Contains:
Auth implementation
Contact US Authentication
Recaptcha implementation
Contact US Recaptcha Implementation front and backend.
Contact us for Data Submission
Contact us Image Attachments