Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from terraform-0.11-support-SREB-1279-support-pw-auth #1

Merged
merged 6 commits into from
Apr 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 9 additions & 24 deletions iam.tf
Original file line number Diff line number Diff line change
@@ -1,22 +1,7 @@
# ---------------------------------------------------------------------------------------------------------------------
# CREATE IAM POLICY RULES FOR SFTP BUCKET
# ---------------------------------------------------------------------------------------------------------------------

locals {
s3_actions = {
"rw" = [
"s3:PutObject",
"s3:GetObject",
"s3:GetObjectVersion",
]
"ro" = [
"s3:GetObject",
"s3:GetObjectVersion",
]
}
}

data "aws_iam_policy_document" "transfer_server_assume_role" {
data "aws_iam_policy_document" "transfer_user_assume_role" {
statement {
effect = "Allow"
actions = ["sts:AssumeRole"]
Expand All @@ -28,7 +13,7 @@ data "aws_iam_policy_document" "transfer_server_assume_role" {
}
}

data "aws_iam_policy_document" "transfer_server_assume_policy" {
data "aws_iam_policy_document" "transfer_user_assume_policy" {
statement {
effect = "Allow"

Expand Down Expand Up @@ -71,13 +56,13 @@ data "aws_iam_policy_document" "transfer_server_assume_policy" {
# special = false
# }

resource "aws_iam_role" "transfer_server_assume_role" {
name = "${var.iam_name}-${var.username}"
assume_role_policy = data.aws_iam_policy_document.transfer_server_assume_role.json
resource "aws_iam_role" "transfer_user_assume_role" {
name = "${var.iam_name}-user-role"
assume_role_policy = data.aws_iam_policy_document.transfer_user_assume_role.json
}

resource "aws_iam_role_policy" "transfer_server_policy" {
name = "transfer-${var.transfer_server_id}-${var.username}"
role = aws_iam_role.transfer_server_assume_role.name
policy = data.aws_iam_policy_document.transfer_server_assume_policy.json
resource "aws_iam_role_policy" "transfer_user_policy" {
name = "${var.iam_name}-user-policy"
role = aws_iam_role.transfer_user_assume_role.name
policy = data.aws_iam_policy_document.transfer_user_assume_policy.json
}
19 changes: 19 additions & 0 deletions locals.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
locals {
s3_actions = {
"rw" = [
"s3:PutObject",
"s3:GetObject",
"s3:GetObjectVersion",
]
"ro" = [
"s3:GetObject",
"s3:GetObjectVersion",
]
}
user_secret = {
Password = var.transfer_server_enable_password_auth ? random_id.user_password_random_id[0].b64 : ""
Role = aws_iam_role.transfer_user_assume_role.arn
HomeDirectory = "/${var.s3_bucket_name}/${var.s3_bucket_folder}${var.s3_bucket_folder == "" ? "" : "/"}"
PublicKey = var.transfer_server_enable_password_auth ? var.ssh_public_keys[0] : "" # TODO add warning if more than one
}
}
23 changes: 20 additions & 3 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,32 @@ data "aws_s3_bucket" "bucket" {
# ---------------------------------------------------------------------------------------------------------------------

resource "aws_transfer_user" "transfer_user" {
count = var.transfer_server_enable_password_auth ? 0 : 1
server_id = var.transfer_server_id
role = aws_iam_role.transfer_server_assume_role.arn
role = aws_iam_role.transfer_user_assume_role.arn
home_directory = "/${data.aws_s3_bucket.bucket.id}/${var.s3_bucket_folder}"
user_name = var.username
}

resource "aws_transfer_ssh_key" "transfer_ssh_key" {
count = length(var.ssh_public_keys)
count = var.transfer_server_enable_password_auth ? 0 : var.ssh_public_keys_length
server_id = var.transfer_server_id
user_name = aws_transfer_user.transfer_user.user_name
user_name = var.username
body = var.ssh_public_keys[count.index]
}

resource "aws_secretsmanager_secret" "user_secret" {
count = var.transfer_server_enable_password_auth ? 1 : 0
name = "SFTP/${var.username}"
}

resource "random_id" "user_password_random_id" {
count = var.transfer_server_enable_password_auth ? 1 : 0
byte_length = 32
}

resource "aws_secretsmanager_secret_version" "example" {
count = var.transfer_server_enable_password_auth ? 1 : 0
secret_id = aws_secretsmanager_secret.user_secret[count.index].id
secret_string = jsonencode(local.user_secret)
}
4 changes: 4 additions & 0 deletions outputs.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
output "user_password" {
value = local.user_secret["Password"]
sensitive = true
}
9 changes: 9 additions & 0 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ variable "ssh_public_keys" {
description = "List of raw SSH public keys."
}

variable "ssh_public_keys_length" {
default = 0
}

variable "transfer_server_id" {
type = string
description = "ID of the transfer server to use."
Expand All @@ -32,3 +36,8 @@ variable "access_type" {
variable "iam_name" {
type = string
}

variable "transfer_server_enable_password_auth" {
description = "Boolean for whether this transfer server uses password auth"
default = false
}
4 changes: 0 additions & 4 deletions versions.tf

This file was deleted.