Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to return API response or dowload labels on checkout #1

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

dahoo
Copy link

@dahoo dahoo commented Mar 28, 2019

No description provided.

@dahoo dahoo self-assigned this Mar 28, 2019
@dahoo dahoo requested a review from nhoffmann March 28, 2019 13:17
Copy link

@nhoffmann nhoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test?

@dahoo dahoo force-pushed the feature/return-repsonse-on-checkout branch from c10d2ac to a629251 Compare March 28, 2019 16:57
@dahoo dahoo force-pushed the feature/return-repsonse-on-checkout branch from a629251 to 159cce3 Compare March 28, 2019 17:05
@dahoo dahoo requested a review from nhoffmann March 28, 2019 17:05
Copy link

@nhoffmann nhoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor style issues, LGTMO

spec/office_spec.rb Outdated Show resolved Hide resolved
spec/office_spec.rb Outdated Show resolved Hide resolved
@dahoo dahoo merged commit da10675 into master Mar 29, 2019
@dahoo dahoo deleted the feature/return-repsonse-on-checkout branch March 29, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants