Change array filter with better performance

askirmas · Feb 27, 2021 · 4ac536f · 4ac536f
1 parent 8cdcf27
commit 4ac536f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/core.ts b/src/core.ts
@@ -48,8 +48,8 @@ function resolver(
       keys[i] = act
   }
 
-  //TODO Compare `.flat()`, `.filter(Boolean)` or `.filter(idfn)`
-  const filtered = keys.filter(Boolean)
+  //TODO https://measurethat.net/Benchmarks/Show/11866/1/arrayfilter
+  const filtered = keys.filter(x => x)
 
   return filtered.length === 0 ? EMPTY_ARRAY : filtered
 }
@@ -65,4 +65,4 @@ function joinWithLead(value: Falsy|ClassHash, arr: undefined | string | readonly
     return str2
 
   return `${str1} ${str2}`
-}
+}
diff --git a/src/sandbox/double-shape.ts b/src/sandbox/double-shape.ts
@@ -26,7 +26,7 @@ function _doubleShape<
 ) {
   const {applied, classnames, className} = ctx  
   //@ts-expect-error
-  , nextApplied = !applied ? [] : applied.push(...args.filter(Boolean)) as Record<U | keyof A, ClassHash|boolean>[] 
+  , nextApplied = !applied ? [] : applied.push(...args.filter(x => x)) as Record<U | keyof A, ClassHash|boolean>[] 
 
   , host = <
       // T extends {[K in Exclude<S, U | keyof A>]?: boolean} | {[K in Exclude<S, U | keyof A>]?: ClassHash}
@@ -83,7 +83,7 @@ function _doubleShape<
     withClassName && className,
     injection,
     args.flat().join(" ")
-  ].filter(Boolean)
+  ].filter(x => x)
   .join(" ")
 
   host["className"] = calced