Fix #12: Links where the label has dashes (-) do not get parsed

askonomm · Apr 10, 2022 · da5edae · da5edae
1 parent 8aa7f6a
commit da5edae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/clarktown/parsers/link_and_image.clj b/src/clarktown/parsers/link_and_image.clj
@@ -13,7 +13,7 @@
   "Renders all occurring links and images."
   [block _]
   (loop [block block
-         matches (-> (re-seq #"\!?\[(\w+( \w+)*)\]\((.*?)\)" block)
+         matches (-> (re-seq #"\!?\[([a-zA-Z0-9\-\.\,]+( [a-zA-Z0-9\-\.\,]+)*)\]\((.*?)\)" block)
                      distinct)]
     (if (empty? matches)
       block

diff --git a/test/clarktown/parsers/link_and_image_test.clj b/test/clarktown/parsers/link_and_image_test.clj
@@ -9,6 +9,9 @@
     (is (= (link-and-image/render "[This is a link](https://example.com)" nil)
            "<a href=\"https://example.com\">This is a link</a>"))
 
+    (is (= (link-and-image/render "[This-is-a-link](https://example.com)" nil)
+           "<a href=\"https://example.com\">This-is-a-link</a>"))
+
     (is (= (link-and-image/render "[x] [label](link)" nil)
            "[x] <a href=\"link\">label</a>"))