Fix to get threshold 0 working as documented #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt list is guaranteed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Let me know what you think |
|
@allevo can you please take a look at this? |
micheleriva
approved these changes
Feb 22, 2024
allevo
reviewed
Feb 22, 2024
|
I put a comment, but generally, it is ok for me! |
Co-authored-by: Tommaso Allevi <tomallevi@gmail.com>
Added changes, thanks! |
micheleriva
reviewed
Feb 22, 2024
|
Thank you @valstu , will release this in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a suggestion to fix #642. Instead of two sets, one for token counts and one for scores we combine them into a single set. Now when sorting the list it guarantees that they're in right order. Read further information and try the test case of a bug on Replit, mentioned in the issue #642