Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project build issues #796

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix project build issues #796

merged 2 commits into from
Sep 26, 2024

Conversation

matijagaspar
Copy link
Contributor

  • Changed node version in .nvmrc to 20 (18 fails the build)
  • Removed conflicting configuration for swc: either jsc or env (removed env)
  • fixed ts confings so ts builds pass
  • fixed a test run script of plugin-astro (--loader no longer supported)
  • plugin-docusaurs-v3 fixed postbuild.sh to not fail if dist directory is missing
  • fixed so pnpm run lint passes

@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024

@matijagaspar is attempting to deploy a commit to the OramaSearch Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:30pm

allevo
allevo approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

micheleriva
micheleriva approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@micheleriva micheleriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@micheleriva micheleriva merged commit 463b6e0 into askorama:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allevo allevo allevo approved these changes

@micheleriva micheleriva micheleriva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matijagaspar @allevo @micheleriva