Conversion to support both Python 2.7 and Python 3.5 #5

danizen · 2018-09-21T02:06:24Z

Hi,

I'm hoping this addresses #3 and #4. I'm also hoping you are willing to act as a host to work on this software - I understand you've probably moved on, but if you can tell me how to run the various pieces, we can begin to get it back in working order.

If you look at my github profile, you'll be able to see my interest. I've brought the OCCS/AB branch of the National Library of Medicine to Python, and as we upgrade our ILS, our cataloging/meta-data workflow depends on my getting this or some other well-supported MARC metasearch working with Python 3.

- Run 2to3 on the changed files - Added some from __future__, but not everywhere - new.classobj to type() - Got to first real error

- The ability to run it as an interactive script is preserved

danizen · 2018-09-21T04:09:14Z

Well, it isn't working as well as I thought. tox error. Adding a travis-ci.org build is helping. Give it a couple of days.

- Idea is to use mkdocs, more modern

PyZ3950/CQLParser.py

cclauss · 2021-02-02T13:43:45Z

PyZ3950/CQLParser.py

@@ -136,7 +136,7 @@ class ModifiableObject:
    modifiers = []

    def __getitem__(self, k):
-        if (type(k) == types.IntType):
+        if (type(k) == int):


PEP8: Use isinstance()

cclauss · 2021-02-02T13:45:49Z

PyZ3950/c2query.py

@@ -2,11 +2,10 @@
 #!/usr/local/bin/python2.3

 try:
-    from cStringIO import StringIO
+    from io import StringIO


See comment above.

This code says do X, if that does not work, do X again.

Co-authored-by: Christian Clauss <cclauss@me.com>

danizen · 2021-02-12T20:34:59Z

Timely, they just got our new Alma Z39.50 server running - I will get back to this.

cclauss · 2021-02-12T21:36:57Z

PyZ3950/c2query.py

 #!/usr/local/bin/python2.3
+from io import StringIO


In Python 2 io.StringIO != StringIO.StringIO

https://stackoverflow.com/questions/3410309/what-is-the-difference-between-stringio-and-io-stringio-in-python2-7

Suggested change

from io import StringIO

try:

from StringIO import StringIO # Python 2

except ImportError:

from io import StringIO # Python 3

mogul · 2021-07-22T20:57:35Z

Hi there @cclauss and @danizen, what are the prospects for getting this PR merged any time soon?

cclauss · 2021-07-22T23:33:26Z

I am not a maintainer and have no rights to merge pull requests.

mogul · 2021-07-23T15:43:37Z

My apologies! 😊

@asl2, are you able to respond?

asl2 · 2021-07-25T21:22:02Z

My apologies for not responding earlier. I haven't done anything Z3950-related (or indeed library-related) in a while.

This is fine as far as it goes, but when I try to run under Python3 I get the following traceback:

Traceback (most recent call last):
File "test1.py", line 33, in
main()
File "test1.py", line 28, in main
for r in get_results():
File "test1.py", line 8, in get_results
conn = zoom.Connection ('z3950.loc.gov', 7090)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/zoom.py", line 276, in init
self.connect()
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/zoom.py", line 302, in connect
optionslist = options, **initkw)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/z3950.py", line 511, in init
('initRequest', InitReq), 'initResponse')
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/z3950.py", line 529, in transact
b = self.encode_ctx.encode (APDU, to_send)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 622, in encode
spec.encode (self, data)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 1192, in encode
ctyp.encode (ctx, val)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 858, in encode
self.typ.encode (ctx, val)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 796, in encode
self.encode_val (ctx, val)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 1504, in encode_val
typ.encode (ctx, v)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 858, in encode
self.typ.encode (ctx, val)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 796, in encode
self.encode_val (ctx, val)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 1089, in encode_val
ctx.bytes_write (val)
File "/usr/local/lib/python3.6/dist-packages/PyZ3950/asn1.py", line 633, in bytes_write
raise EncodingError("Bad type to bytes_write")

Perhaps I've done something obvious wrong, but my thought was that PyZ3950 relied on Python 2's identity of string and bytes and would need somewhat more work for a port to Python 3.

I'll try to free up some time to look at this more closely.

#5]

mogul · 2021-07-26T06:59:01Z

I saw the commit fixing the tests. Thanks so much for taking care of this!

cclauss · 2021-07-26T08:41:05Z

Please see #6 for other Py3 changes needed.

Dan Davis and others added 12 commits September 20, 2018 14:04

Beginning of changes to support both 2 and 3.

539566c

- Run 2to3 on the changed files - Added some from __future__, but not everywhere - new.classobj to type() - Got to first real error

Use asn1 module - not yet integrated

c44245f

Get it working again in Python 2.

4092110

Run 2to3 on more code and verify test/test1.py still works

fee7425

Turn test/test1.py into our first python test

40379f6

- The ability to run it as an interactive script is preserved

Achieve a tox test that works on both py35 and py27.

754f772

Add products created by ./mkrel to the ignored files.

2112cbe

Update README.md and make setup.py commented print work.

24fbe1d

Add a YAML builder.

99f3bd1

Get better environment going.

1b37beb

Resolve some Python 2 to 3 issues.

a3f0590

Add build badge

e458345

danizen added 8 commits September 21, 2018 00:10

Correct build image.

1ff4a56

More integer division stuff.

b2e1afb

Attempt to parse z3950_1995 with asn1ate to produce PDUs.

7afd1e1

Better plan for tests.

3c47e21

Remove embedded lex.py and yacc.py - if we use ply, it is as a dep.

acf08e0

Move docs someplace else, with plan to use mkdocs.

0ff598c

Remove mkdoc.py and simplify mkrel

3e698a1

- Idea is to use mkdocs, more modern

Simplify pqf.py - don't know when if ever it is called.

7fa1c84

cclauss reviewed Feb 2, 2021

View reviewed changes

PyZ3950/CQLParser.py Outdated Show resolved Hide resolved

cclauss reviewed Feb 2, 2021

View reviewed changes

cclauss mentioned this pull request Feb 2, 2021

GitHub Action to lint Python code #6

Merged

Update PyZ3950/CQLParser.py

0b835ed

Co-authored-by: Christian Clauss <cclauss@me.com>

Small changes in accordance with comments on pull.

6d44a4a

cclauss reviewed Feb 12, 2021

View reviewed changes

mogul mentioned this pull request Jul 22, 2021

PyZ3950 Py3 + CKAN 2.9 support GSA/datagov-ckan-multi#576

Closed

18 tasks

asl2 merged commit 9aeffea into asl2:master Jul 25, 2021

asl2 added a commit that referenced this pull request Jul 25, 2021

Fix so test/test1.py runs successfully for me under Python 2.7 and 3.6 [

b92e295

#5]

nickumia-reisys mentioned this pull request Dec 25, 2021

Validating CKAN2.9 & Python3 framework with catalog GSA/data.gov#3401

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conversion to support both Python 2.7 and Python 3.5 #5

Conversion to support both Python 2.7 and Python 3.5 #5

danizen commented Sep 21, 2018

danizen commented Sep 21, 2018

cclauss Feb 2, 2021

cclauss Feb 2, 2021

danizen commented Feb 12, 2021

cclauss Feb 12, 2021

mogul commented Jul 22, 2021

cclauss commented Jul 22, 2021

mogul commented Jul 23, 2021

asl2 commented Jul 25, 2021

mogul commented Jul 26, 2021

cclauss commented Jul 26, 2021

-from io import StringIO
+try:
+    from StringIO import StringIO  # Python 2
+except ImportError:
+    from io import StringIO  # Python 3

Conversion to support both Python 2.7 and Python 3.5 #5

Conversion to support both Python 2.7 and Python 3.5 #5

Conversation

danizen commented Sep 21, 2018

danizen commented Sep 21, 2018

cclauss Feb 2, 2021

Choose a reason for hiding this comment

cclauss Feb 2, 2021

Choose a reason for hiding this comment

danizen commented Feb 12, 2021

cclauss Feb 12, 2021

Choose a reason for hiding this comment

mogul commented Jul 22, 2021

cclauss commented Jul 22, 2021

mogul commented Jul 23, 2021

asl2 commented Jul 25, 2021

mogul commented Jul 26, 2021

cclauss commented Jul 26, 2021