Skip to content
This repository was archived by the owner on Jan 13, 2024. It is now read-only.

/bin/sh: 1: npm: not found #283

Closed
alfieyfc opened this issue Aug 10, 2023 · 7 comments
Closed

/bin/sh: 1: npm: not found #283

alfieyfc opened this issue Aug 10, 2023 · 7 comments

Comments

@alfieyfc
Copy link

Hello, thanks for this great action!

We've been using this for quite some time without any issues. Suddenly, since recent hours, we started to see this error:
image

Error: Command failed: npm install --quiet conventional-changelog-angular@latest
/bin/sh: 1: npm: not found

We suspect this may have to do with the latest release from #267. Was there anything intended for us to change on our side for using the latest release?

@JackRhodes
Copy link

JackRhodes commented Aug 10, 2023

I have hit the same issue!

I have mitigated by rolling back to the previous version

- uses: actions/aslafy-z_conventional-pr-title-action@v3

to

- uses: actions/aslafy-z_conventional-pr-title-action@v3.0.1

One thing to note to people doing this. If you are using the default action linked on the README, then the action will still be using the old one on the PR you create with this change. I had to bypass PR policies and merge this, it then fixed any open PR's I had.

It would be great if the breaking change @alfieyfc has highlighted could be reverted ASAP as this is highly disruptive to anyone pinning to @v3 and uses this action on many repos.

@aslafy-z
Copy link
Owner

Hey there! Sorry for the inconvenience. Can you please try again, branch v3 is updated with the reverted version.

@iamludal In the current implementation, users can specify a package name for their conventionalcommits preset. This package will be installed with NPM if not present. The way this is done is not supported by your implementation at #267. Let's work a bit more on this before releasing in a new major.

@iamludal
Copy link
Contributor

iamludal commented Aug 10, 2023

Hi! Sorry for the inconvenience.

@aslafy-z Let's release a new major when the change will be stable as you suggested. I've seen you reverted the commit, does the error still happens? Or this issue can now be closed?

@aslafy-z
Copy link
Owner

The issue should be gone now, can you confirm @JackRhodes @alfieyfc? Thank you

@thiagownt
Copy link

Hi, I think you have deleted a release. I think it would be better if a new patch was released instead of removing the version. The new version was working on my repos and dependabot auto-merged the changes and now my workflows are broken because the release has been retracted.

@aslafy-z
Copy link
Owner

aslafy-z commented Aug 10, 2023

@thiagownt Noted. I re-created tags with #267 reverted as v3.1.0 and v3.1.1. I will make sure this does not happen again in the future. I will proceed and close this issue. Thank you for reporting!

@thiagownt
Copy link

@aslafy-z thanks for that. It is all working now 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants