This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
feat(action): migrate from docker to node #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aslafy-z, any update on this PR? |
|
@iamludal Thank you for the contribution! Can you please rebase your branch on the latest code? Thank you! |
|
@aslafy-z You're welcome! Sure. |
This migration improves performance because no Docker image should be created at each run. The `dist/index.js` can run directly, reducing the time needed for the action to run. The `dist/index.js` script is automatically updated by Semantic Release when a new release is created with `npm run build` command. This npm command relies on `@vercel/ncc` to merge files to a single `dist/index.js` file. I also added the `@semantic-release/npm` plugin in order to update the `version` field in `package.json` and `package-lock.json`. I set `npmPublish` to `false` because we don't need it. Before:  After: 
iamludal
force-pushed
the
from-docker-to-node
branch
from
054c612 to
e99b2c2
Compare
|
By the way, does PR #264 still makes sense with the current one? |
aslafy-z
pushed a commit
that referenced
this pull request
Aug 9, 2023
## [3.1.0](v3.0.1...v3.1.0) (2023-08-09) ### Features * **action:** migrate from docker to node ([#267](#267)) ([6fd10ff](6fd10ff))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
renovate bot
referenced
this pull request
in 4m-mazi/gh-test
Aug 11, 2023
….1 (#374) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [aslafy-z/conventional-pr-title-action](https://togithub.com/aslafy-z/conventional-pr-title-action) | action | minor | `v3.0.1` -> `v3.1.1` | --- ### Release Notes <details> <summary>aslafy-z/conventional-pr-title-action (aslafy-z/conventional-pr-title-action)</summary> ### [`v3.1.1`](https://togithub.com/aslafy-z/conventional-pr-title-action/releases/tag/v3.1.1) [Compare Source](https://togithub.com/aslafy-z/conventional-pr-title-action/compare/v3.1.0...v3.1.1) #### This release is a mirror of [v3.1.0](https://togithub.com/aslafy-z/conventional-pr-title-action/releases/tag/v3.1.0) ### [`v3.1.0`](https://togithub.com/aslafy-z/conventional-pr-title-action/releases/tag/v3.1.0) [Compare Source](https://togithub.com/aslafy-z/conventional-pr-title-action/compare/v3.0.1...v3.1.0) #### What's Changed - docs(README): no input is required by [@​iamludal](https://togithub.com/iamludal) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/265](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/265) - chore(deps-dev): bump jest from 29.4.2 to 29.5.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/263](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/263) - docs: minor documentation improvements by [@​iamludal](https://togithub.com/iamludal) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/266](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/266) - test: add assertions and run tests before creating a release by [@​iamludal](https://togithub.com/iamludal) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/268](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/268) - feat(action): migrate from docker to node by [@​iamludal](https://togithub.com/iamludal) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/267](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/267) - revert: feat(action): migrate from docker to node by [@​aslaFY-Z](https://togithub.com/aslaFY-Z) in https://github.com/aslafy-z/conventional-pr-title-action/commits/2ce59b07f86bd51b521dd088f0acfb0d7fdac55e - chore(deps): bump conventional-changelog-conventionalcommits from 5.0.0 to 6.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/278](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/278) - chore(deps-dev): bump jest from 29.5.0 to 29.6.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/282](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/282) - chore(deps): bump semver from 5.7.1 to 5.7.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/281](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/281) - chore(deps): bump conventional-commits-parser from 3.2.4 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/aslafy-z/conventional-pr-title-action/pull/271](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/271) #### New Contributors - [@​iamludal](https://togithub.com/iamludal) made their first contribution in [https://github.com/aslafy-z/conventional-pr-title-action/pull/265](https://togithub.com/aslafy-z/conventional-pr-title-action/pull/265) **Full Changelog**: aslafy-z/conventional-pr-title-action@v3.0.1...v3.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Mogyuchi/gh-test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration improves performance because no Docker image should be created at each run. The
dist/index.jscan run directly, reducing the time needed for the action to run.The
dist/index.jsscript is automatically updated by Semantic Release when a new release is created withnpm run buildcommand. This npm command relies on@vercel/nccto merge files to a singledist/index.jsfile.I also added the
@semantic-release/npmplugin in order to update theversionfield inpackage.jsonandpackage-lock.json. I setnpmPublishtofalsebecause we don't need it.Before:
After:
