This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
feat: Docker optimizations to improve run time #286
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #285
This PR improves run time by making the following Docker optimizations:
ghcr
instead of building it at every run@vercel/ncc
and multi-stage build to reduce the final image size (from 240MB to 180MB, see below)Migrating to a node engine instead of Docker seems more difficult. To be able to install a
npm
package, users should add an extra stepactions/setup-node
before using the action, which is not convenient. Another way to install anpm
package is to use thenpm
programmatic API, but it has been removed since version 8.0.0, so I don't think it's a great idea.Anyway, performance improvements are not as significant as using a node engine. But with these changes, the Docker image does not contain the entire
node_modules
folder and the image is not built at each run.Results
Before:
After: