WIP 239 Conversation Notifications #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit effectively adds New Conversation Notifications by enhancing the existing message notification system. Conversation#mailing_list is added to return the list of people to send emails to regarding that Conversation. This list contains the participants (people who have actually authored messages) and if assigned the agent. If unassigned the entire team (Account.people) are added.
|
If you think this is good, go ahead and merge it. No need to ask for permission :) |
austinylin
added a commit
that referenced
this pull request
Jan 26, 2014
WIP 239 Conversation Notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively adds New Conversation Notifications by enhancing the existing message notification system.
Conversation#mailing_list is added to return the list of people to send emails to regarding that Conversation. This list contains the participants (people who have actually authored messages) and if assigned the agent. If unassigned the entire team (Account.people) are added.
So when a new message comes in the email notification list is now based on assigned status:
WIP: https://assemblymade.com/helpful/wips/239