Skip time-out flash #292
Skip time-out flash #292
Conversation
|
Closing for now. Let me know if we should still merge this. |
|
@vanstee It sucks that this is so hard to reproduce. Somehow the timeout setting in the devise config doesn't seem to do a lot, so I can't test. Do you have any suggestions how to easily test this? I'm fairly sure your fix isn't going to work as this is a separate flash message being used by Devise internally that shouldn't be displayed. |
|
@wesleylancel Oh yeah that's how you disable devise flash messages, by making them an empty string. Seems kinda weird. |
|
@vanstee Yeah, but the "true" flash message isn't actually a flash message meant for display. It's Devise using the flash variable to pass data between pages. |
|
@wesleylancel Oh gotcha. Let me take a look. I can probably force a session to expire and try to repro it. |
|
Actually I'll just try what they recommend here: heartcombo/devise#2787 |
|
@vanstee You mean replacing name == "timedout" with checking wether or not the value is actually a string? |
|
@wesleylancel I think this should work 28d6495 Let me know if I should reopen this. |
@vanstee This should fix the extra flash message containing true after your session has expired. I'm unable to test as I have no expired sessions. Any chance you know a quick solution to test it anyway?