Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CMake} Multi-config builds do not work #25

Open
asmaloney opened this issue Dec 31, 2022 · 0 comments
Open

{CMake} Multi-config builds do not work #25

asmaloney opened this issue Dec 31, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@asmaloney
Copy link
Owner

CMAKE_BUILD_TYPE applies to single-config builds, but not multi-config (e.g. Visual Studio, XCode) ones. For those we should be using generator expressions.

The fix for this is not obvious at the moment because of the way the template files are processed and because godot-cpp itself does not work properly for multi-config.

I have submitted fixes for godot-cpp in this PR.

Once it's fixed in godot-cpp I will revisit how the templates work here.

@asmaloney asmaloney added the bug Something isn't working label Dec 31, 2022
asmaloney added a commit that referenced this issue Dec 31, 2022
Not ideal, but we need a fix to godot-cpp.

See #25.
asmaloney added a commit that referenced this issue Dec 31, 2022
Not ideal, but we need a fix to godot-cpp.

See #25.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant