Fix potential invalid range exceptions when reading integer nodes #275
Labels
bug
Something isn't working
Comments
asmaloney
added a commit
that referenced
this issue
Jan 11, 2024
…uctors This means we don't have to add more arguments to constructors like we did with the float node implementation (which was also changed). When reading, we only call the validation if we actually read in a value for Integer, ScaledInteger, and Float nodes (see E57XmlParser.cpp). Fixes #275
asmaloney
added a commit
that referenced
this issue
Jan 11, 2024
…uctors (#278) This means we don't have to add more arguments to constructors like we did with the float node implementation (which was also changed). When reading, we only call the validation if we actually read in a value for Integer, ScaledInteger, and Float nodes (see E57XmlParser.cpp). Fixes #275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This has to do with default values on the prototype nodes when reading (see #246).
#250 fixed it for float nodes.
The same should probably be done for
IntegerandScaledInteger.The text was updated successfully, but these errors were encountered: