Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{cmake} Remove E57_VISIBILITY_HIDDEN option #259

Merged
merged 1 commit into from
Aug 15, 2023
Merged

{cmake} Remove E57_VISIBILITY_HIDDEN option #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ option( E57_ENABLE_DIAGNOSTIC_OUTPUT "Include code for diagnostic output using d
option( E57_WRITE_CRAZY_PACKET_MODE "Compile library to enable reader-stressing packets" OFF )

# Other compile options
option( E57_VISIBILITY_HIDDEN "Compile library with hidden symbol visibility" ON )

# Link-time optiomization
# CMake forces "thin" LTO (see https://gitlab.kitware.com/cmake/cmake/-/issues/23136)
Expand Down Expand Up @@ -181,14 +180,6 @@ target_compile_definitions( E57Format
$<$<BOOL:${E57_WRITE_CRAZY_PACKET_MODE}>:E57_WRITE_CRAZY_PACKET_MODE>
)

if ( E57_VISIBILITY_HIDDEN )
set_target_properties( E57Format
PROPERTIES
CXX_VISIBILITY_PRESET hidden
CMAKE_VISIBILITY_INLINES_HIDDEN ON
)
endif()

# sanitizers
include( Sanitizers )

Expand Down Expand Up @@ -230,13 +221,6 @@ option( E57_BUILD_TEST
if ( E57_BUILD_TEST )
message( STATUS "[${PROJECT_NAME}] Testing enabled" )

# If we are building tests, we need access to all the symbols, so override visibility
set_target_properties( E57Format
PROPERTIES
CXX_VISIBILITY_PRESET default
CMAKE_VISIBILITY_INLINES_HIDDEN OFF
)

enable_testing()

add_subdirectory( test )
Expand Down
6 changes: 3 additions & 3 deletions test/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ target_sources( ${PROJECT_NAME}
test_SimpleWriter.cpp
)

# Include internal tests if not building shared lib on Windows.
# The functions aren't exported in the Windows DLLs.
if ( (NOT WIN32) OR (WIN32 AND NOT E57_BUILD_SHARED) )
# Include internal tests if not building shared lib.
# The functions are not exported.
if ( NOT E57_BUILD_SHARED )
target_sources( ${PROJECT_NAME}
PRIVATE
test_StringFunctions.cpp
Expand Down