Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper install configuration for cmake #28

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Added proper install configuration for cmake #28

merged 1 commit into from
Mar 13, 2020

Conversation

artudi54
Copy link
Contributor

I have made some CMake cleanup and added proper install configuration. Now the library can be found with "find_package(E57Format)" or used as module with "add_subdirectory(....)" without the need of any additional configuration.
Library target automatically links the xerces-c library to itself, and specifies proper public/private include directories.
Install command let's you now find the package from any other cmake project with xerces-c dependency already solved.

I have tested this functionalities on both linux and windows. If you find have any problems with this update or something is not working right please let me know.

@asmaloney
Copy link
Owner

Thanks @artudi54.

Do any of these changes require cmake > 3.1?

@artudi54
Copy link
Contributor Author

artudi54 commented Mar 13, 2020

According to the documentation, install, target_compile_definitions, target_include_directories, target_link_libraries and CMakeFindDependencyMacro are all available in CMake 3.1. Every parameter, option or keyword which I used can be found in the docs, so there is no need to increase the minimal version.

@asmaloney asmaloney merged commit c1e1990 into asmaloney:master Mar 13, 2020
@asmaloney
Copy link
Owner

Thank you @artudi54!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants