Prepare for upcoming pytest 7.0 deprecations #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope this can be merged and released to unblock the pytest PR. But it's OK if not, we can add an ignore on our side, it's not a problem. |
|
Apparently we never moved this repo from Travis to GitHub Actions. We should try to do that first. |
|
Sure, I'll try to do it now. |
`collect` is not called on the Item, but on the File.
Since pytest-flakes depends on pytest>=5.0, the check is not necessary.
Since pytest-flakes required python>=3.5, and tokenize.open was added in python 3.2, it's no longer needed.
pytest-flakes is checked as part of pytest's CI. In pytest 7.0 (previously 6.3), `py.path.local`-based arguments to hooks & node ctors are deprecated, so switch to the `pathlib` based replacements on pytest 7.
|
Thanks. Should I make a release with this or are more changes forthcoming? |
|
Except #44, nothing more from me, thanks! |
|
Just released 4.0.4 with your changes. |
nicoddemus
added a commit
to nicoddemus/pytest-flakes
that referenced
this pull request
Dec 1, 2021
This follows up asmeurer#42, we decided that using just `fspath` as the new parameter that users should use would be confusing because it is too close to `path` and also we have `fspath` already in some places of the pytest public API (see pytest-dev/pytest#9283). This PR updates the hook affected by this new change in pytest-dev/pytest#9363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin has had to endure a lot of deprecations from pytest, sorry about that :(
pytest-flakes is checked as part of pytest's CI. In pytest 7.0 (previously 6.3),
py.path.local-based arguments to hooks & node ctors are deprecated, so switch to thepathlibbased replacements on pytest 7.I also cleaned up some no-longer-needed backward compat checks, see the separate commits for those.
Refs pytest-dev/pytest#9232