Feature: smart handling of windows with frame constraints#2737
Open
CCMurphy-dev wants to merge 1 commit intoasmvik:masterfrom
Open
Feature: smart handling of windows with frame constraints#2737CCMurphy-dev wants to merge 1 commit intoasmvik:masterfrom
CCMurphy-dev wants to merge 1 commit intoasmvik:masterfrom
Conversation
Addresses issue asmvik#235 - windows with min/max size constraints (Terminal, Calculator, video players, etc.) are now handled gracefully in BSP layouts. Implementation: - Detect frame constraints by comparing requested vs actual size after resize - Store detected min_size/max_size on window struct for layout calculations - Adjust BSP split ratios to give constrained windows enough space - Center undersized windows within their allocated node frame - Overlap oversized windows toward screen center (not toward edges) - Clamp manual/mouse resizes to detected min/max constraints Safeguards: - Auto-rebalance triggers only once per window (on first constraint detection) - Subsequent resizes skip rebalance, preventing refresh loops - Ratio adjustments clamped to 0.1-0.9 range to prevent extreme splits Files changed: - src/window.h: Added min_size, max_size, has_size_constraints fields - src/window_manager.c: Constraint detection, positioning, and resize clamping - src/view.c: Ratio adjustment based on detected constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #235 - windows with min/max size constraints (Terminal, Calculator, video players, etc.) are now handled gracefully in BSP layouts.
Implementation:
Safeguards:
Files changed: