Extend mtbf time range to also support hours and minutes. #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the definition of "kube-monkey/mtbf".
Alike https://github.com/misgod-yy in #168 we needed a more fine grained control for the mean time between failure. A couple of years ago a coworker of mine took the misgod-yy patches and updated a now very old version of your software, fixed the problems with that code and we have been using this happily ever since for several years now.
The downside of this approach was that we were still using this very old version of the software and recently decided that's not okay anymore. Hence I ported our patches to the newest version of your code and improved it a tiny bit. Please bare with me, this is the first Golang programming I did.
Please review my work. I think it solves all the issues you had with the more early work of https://github.com/misgod-yy. It for instance sticks to minutes, hours and days, it removed the weird naming and last but not least is no breaking change as one can specify days as a simply integer (old style) and as an integer with an additional d-unit (new-style).
I hope you like it.