Running setup.py build in Windows in Admin prompt results in Access denied errors

[ellinorcrux]

Hi,

I tried using this tool in an elevated command prompt, but I got some strange "Access is denied" and "undefined reference to f" errors. See image:

If I go to the location of my "root" file, I'm able to build using the go build command in the image above.

I'm on Python 2.7.11, 32 bit on Windows 8

I built Go from source, and I'm on git hash 8f70e1f8a91db6c8a1bcc292766af95e52e8512b

I have gcc installed in MINGW32

This is what my setup.py looks like:

There are a ton of other arguments I didn't include. I have a template for setup.py that I generate for each package I make.

I'm wondering what the best approach to trying to debug this issue is. I've tried looking at the files its complaining about, but I can't find all of them. Any tips?

Thanks!

[asottile]

Interesting, I haven't actually tried using this on windows yet but I'll give it a poke when I get home -- I'd start with trying to build the examples: https://github.com/asottile/setuptools-golang-examples and see what you run into

[ellinorcrux]

I'll give that a shot. Thanks! Note that using "c-shared" option on go build is not available in Go 1.8 on Windows. Its slated for release in Go 1.9. That's why I had to build from source.

[ellinorcrux]

Ah sorry. Not Go 1.9, should be Go 1.10: golang/go#11058

[ellinorcrux]

I cloned this repository using git, then I commented back in the "setuptools-golang" dependency back in for the "imports_gh" example in the testing folder. I ended up with a very similar result:

[asottile]

Ah, so the first error is actually the meaningful one, seems we probably need to extend this to include whatever link flag that works on windows (similar to #8)

The second error is due to shutil.rmtree failing to clean readonly files on windows -- this is only hiding the previous error -- here's how I've fixed this in the past

[ellinorcrux]

Ah OK! Thank you! Are you planning to put the patch in for the link flag or is that something you would like me to help with?

[asottile]

If you'd like to take a stab at it feel free -- I'm not sure when I'll get to that (something something copious amounts of freetime 😆) -- the shutil bit is pretty easy if you want to lump them together (the shutil patch actually is probably necessary so you can debug at all)

[ellinorcrux]

I put in the shutil fix, and also a fix for converting unicode strings in the env to normal strings: ellinorcrux@728e5f2

The unicode string thing might only be an issue in py27. I'm not sure what effect it would have in py3.

The thing I'm confused about though is that it seems that the '-Wl,--unresolved-symbols=ignore-all' arguments are ignored completely. I am actually using gcc despite being on Windows.

After my fix I now get the following output:

[asottile]

heh yeah, I've hit the environ problem before as well -- they need to be "native" strings on windows (str (bytes) in python2, str (text) in python3).

So python for windows is usually compiled with msvc -- the error messages also look like msvc errors, I'm thinking we'll need to find the "allow undefined symbols" option for msvc.

[ellinorcrux]

I'm pretty certain its using gcc. I tried using "/FORCE" from here: https://msdn.microsoft.com/en-us/library/70abkas3.aspx

But I end up with this:

I'm not sure that MSVC is even supported for "--buildmode=c-shared" option yet, so I'm not sure there's any value in adding the equivalent flags in for it.

[asottile]

hmmmm... I'll have to poke at this -- perhaps I'll be able to look into this more over the holiday weekend -- do you have some directions on how I can get started with building go on windows (at least so I can reproduce what you're looking it 😆 )

[ellinorcrux]

Here's the guide to building from source: https://golang.org/doc/install/source
Take your time :) I'll keep looking into it meanwhile.
Thanks!

[ellinorcrux]

Note that some of the unit tests for the built-in libraries might fail when you install from source. This wasn't a problem for me because I wasn't planning to use those libraries for this project. The installation worked fine otherwise :)

[ellinorcrux]

I played around with this a bit more. It appears the main issue is now the "undefined reference to __imp__Py..." errors. I noticed that one of the things that was getting included was "C:\Python27\PC". This folder actually doesn't exist in my installation. I've noticed it doesn't exist in a fresh installation on another machine either, so this doesn't seem quite right. I think the missing references are meant to be in a file called libpython27.a in the C:\Python27\libs folder, but adding "-IC:\Python27\libs" to CGO_CFLAGS didn't seem to help. Not sure what to try next...

[asottile]

So the way python linking works is kind of odd. When it builds the .so files, it doesn't actually link them against libpython -- they get hooked together at runtime when imported. There's a flag that works well under linux-gcc and clang that ignores the undefined references, I think we just need ot figure out what that correct flag is for windows-gcc.