Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly use gnu-sed on macos #328

Closed
wants to merge 1 commit into from
Closed

Conversation

ssbarnea
Copy link

@ssbarnea ssbarnea commented Mar 27, 2024

  • corrects gnu-sed installation instructions on macos, avoids asking to alter PATH as this might cause problems with other tools, including system ones
  • uses gsed on macos
  • display error message if gnu-sed is missing on macos

Related: #68

- corrects outdated gnu-sed installation instructions on macos
- uses gsed on macos
- display error message if gnu-sed is missing
@ssbarnea ssbarnea marked this pull request as ready for review March 27, 2024 14:06
@ssbarnea
Copy link
Author

@asottile If desired I could try to activate a macos job, so we can avoid the no pragma. Also, I observe that last two versions of python are not even tested. Just let me know if you need a hand.

@asottile
Copy link
Owner

this has already been rejected before, please search closed PRs

@asottile asottile closed this Mar 27, 2024
@ssbarnea
Copy link
Author

With all due respect, i did search both issues and PRs containing 'sed', including closed/rejected ones and I did not find any indication that there is no desire to make it work on macos in a non intrusive way.

The closest thing I found was #137 (comment) which is a comment from you that makes me believe you would want to test for the missing or wrong sed on macos.

PS. 10min later of fully reading all the comments on ~15 tickets and I found a deep comment that 3y old #184 (comment) -- that explains it. Still, I guess you are fully aware that the README.md documentation about prepending gnu sed to PATH is high likely that will break other tools. -- So sorry for trying to improve it.

Repository owner locked as off-topic and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants