Unify exception replacing and rewrite some TimeoutError cases #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Sep 15, 2023
asottile
reviewed
Sep 18, 2023
Comment on lines
13
to
16
| EXC_REWRITE_TARGETS = ( | ||
| exceptions.ExceptionRewriteTarget('socket', 'timeout', (3, 10)), | ||
| exceptions.ExceptionRewriteTarget('asyncio', 'TimeoutError', (3, 11)), | ||
| ) |
There was a problem hiding this comment.
oh I meant that these can all just live in the exceptions plugin -- no need to separate these
asottile
force-pushed
the
timeout-errors
branch
from
52794e6
to
719c224
Compare
|
I rewrote things a bit -- it was doing a bunch of repeated O(N*M) work and didn't work for multiple names being rewritten at once I also removed all the formatting and magic from the testsuite -- it made it a lot harder to understand what was actually being tested |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #819. Moved
oserror_aliasesintoexceptions& made it generalizable. AddedExceptionRewriteTargetobject to store module & builtin rewrite config.