-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename mock attrs in py3 #99
Conversation
ca0735e
to
5873a30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also handle import mock
=> from unittest import mock
? (or at least add a test demonstrating it works, it might already work!)
I believe there's also some sub-namespaces inside mock
that sometimes get auto-populated by greedy IDEs that we could do as well (iirc from mock.mock import Mock
?) (don't worry about this for a first pass though -- fine to ignore this suggestion)
It doesn't already work, looks like the code bails out here. Added an xfailing test in the meantime, not sure how useful that is but it's something 😛
Took a stab at it in this PR. Looks like all the attributes are eligible for this rewrite |
🥂 ty! |
Resolves #80