Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: outputs && configure verbs don't accept common flags #365

Closed
1 task
alexeagle opened this issue Dec 14, 2022 · 1 comment
Closed
1 task

[Bug]: outputs && configure verbs don't accept common flags #365

alexeagle opened this issue Dec 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@alexeagle
Copy link
Member

alexeagle commented Dec 14, 2022 •
edited by gregmagolan
Loading

What happened?

$ bazel outputs --invocation_id=5f51c87f-ac69-49a2-a800-e3969abffd90 -- "attr("tags", "\bdeliverable\b", //...)" ExecutableHash
Error: unknown flag: --invocation_id

$ bazel configure --config=workflows
Error: unknown flag: --config

Version

5.0.3

How to reproduce

No response

Any other information?

No response

Fund our work

  • Sponsor our open source work by donating a bug bounty
@alexeagle alexeagle added the bug Something isn't working label Dec 14, 2022
@gregmagolan gregmagolan changed the title [Bug]: outputs verb doesn't accept common flags [Bug]: outputs && configure verbs don't accept common flags Jun 28, 2023
@gregmagolan
Copy link
Member

I have a fix for the outputs verb since it should accept all flags the aquery accepts. Seems to be that configure should not accept any common bazel flags since its not calling bazel under the hood.

gregmagolan added a commit that referenced this issue Aug 24, 2023
@gregmagolan
fix: outputs and outputs-bbclientd should take all aquery flags (#3235)
192147a 
Fixes #365.

---

### Type of change

- Bug fix (change which fixes an issue)

**For changes visible to end-users**

- Suggested release notes are provided below:

Aspect CLI outputs command now accepts all Bazel aquery flags since
`outputs` makes a `bazel aquery` call under the hood.

### Test plan

- Manual testing; please provide instructions so we can reproduce:

Manually tested that I could pass `--invocation_id` to an `aspect
outputs` call.

GitOrigin-RevId: d22ba7a2905db94fe610b7d552f9e0b61a8fcf84
alexeagle pushed a commit that referenced this issue Aug 31, 2023
@gregmagolan @alexeagle
fix: outputs and outputs-bbclientd should take all aquery flags (#3235)
ed2daed 
Fixes #365.

---

### Type of change

- Bug fix (change which fixes an issue)

**For changes visible to end-users**

- Suggested release notes are provided below:

Aspect CLI outputs command now accepts all Bazel aquery flags since
`outputs` makes a `bazel aquery` call under the hood.

### Test plan

- Manual testing; please provide instructions so we can reproduce:

Manually tested that I could pass `--invocation_id` to an `aspect
outputs` call.

GitOrigin-RevId: d22ba7a2905db94fe610b7d552f9e0b61a8fcf84
alexeagle pushed a commit that referenced this issue Aug 31, 2023
@gregmagolan @alexeagle
fix: outputs and outputs-bbclientd should take all aquery flags (#3235)
6726e5e 
Fixes #365.

---

### Type of change

- Bug fix (change which fixes an issue)

**For changes visible to end-users**

- Suggested release notes are provided below:

Aspect CLI outputs command now accepts all Bazel aquery flags since
`outputs` makes a `bazel aquery` call under the hood.

### Test plan

- Manual testing; please provide instructions so we can reproduce:

Manually tested that I could pass `--invocation_id` to an `aspect
outputs` call.

GitOrigin-RevId: d22ba7a2905db94fe610b7d552f9e0b61a8fcf84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Open Source
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @gregmagolan