fix: tsconfig paths are not expanded correctly for tsconfigs and libs not placed at workspace root #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synced from #500 by joelMuehlena: fix: tsconfig paths are not expanded correctly for tsconfigs and libs not placed at workspace root (#499) --- Fix #499 ### Test plan - Covered by existing test cases - New test cases added ### General This fix ensures, that if an expanded import path like specified in the corresponding tsconfig.json (of a file which for example lays in the following space <root>/projects/p1) is not absolute e.g. `@org/liba/* -> ./*: @org/liba/test` will be expanded to `projects/p1/test`. Otherwise gazelle has issues resolving the correct imports. Closes #500 --------- Co-authored-by: Joel Mühlena <joel.rene@muehlena.de> GitOrigin-RevId: 57f6b0b18df932cc543d334b4eac1118e70674cf
jbedard
approved these changes
Aug 14, 2023
alexeagle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/dc6e3f9df4b286b3417a45c73b9dfa7a0500911a..57f6b0b18df932cc543d334b4eac1118e70674cf