Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support jest config function #127

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

panjiesw
Copy link
Contributor

fixes #126

Type of change

  • Bug fix (change which fixes an issue)
  • New feature or functionality (change which adds functionality)
  • Style (white-space, formatting, etc...)
  • Refactor (a code change that neither fixes a bug or adds a new feature)
  • Performance (a code change that improves performance)
  • Documentation (updates to documentation or READMEs)
  • Chore (any other change that doesn't affect source or test files)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)
  • Relevant documentation has been updated
  • Suggested release notes are provided below:

Test plan

How has this been tested?

  • Covered by existing test cases
  • New test cases added
  • Manual testing

If part of the test plan included manual testing, please provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@jbedard
Copy link
Member

jbedard commented Apr 21, 2023

Awesome 👍 🎉

Anything still in progress or is it good to go?

@panjiesw
Copy link
Contributor Author

@jbedard no pending changes, good to go from me 🙂

@jbedard jbedard merged commit 3d76b17 into aspect-build:main Apr 21, 2023
@panjiesw
Copy link
Contributor Author

@jbedard any chance of a new release that will include this soon?

@jbedard
Copy link
Member

jbedard commented Apr 22, 2023

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Support Jest config returning function
3 participants