Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Aspect Workflows CI (on AWS + Buildkite) #154

Merged
merged 1 commit into from
Aug 20, 2023
Merged

chore: add Aspect Workflows CI (on AWS + Buildkite) #154

merged 1 commit into from
Aug 20, 2023

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Aug 17, 2023 •
edited
Loading

Run CI on an Aspect Workflows deployment on AWS + Buildkite. Just the root WORKSPACE & buildifier for now.

Pipelines:

https://buildkite.com/aspect/rules-jest
https://buildkite.com/aspect/rules-jest-warming

These pipelines are part of the rules_jest Buildkite Cluster: https://buildkite.com/organizations/aspect/clusters/7c946573-2ac7-42a6-8b1e-4c17518cf97e/pipelines

I've included the terraform in this repo to serve as a live working example for the full configuration of Aspect Workflows for AWS + Buildkite.

Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • Manual testing; please provide instructions so we can reproduce:

Observe Aspect Workflows on Buildkite working.

@gregmagolan gregmagolan force-pushed the aspect_workflows branch 4 times, most recently from e1b8142 to 2f39676 Compare August 17, 2023 07:21
@gregmagolan gregmagolan marked this pull request as ready for review August 17, 2023 07:26
@gregmagolan gregmagolan force-pushed the aspect_workflows branch 2 times, most recently from 831d6da to 6614aa1 Compare August 17, 2023 07:37
@gregmagolan gregmagolan force-pushed the aspect_workflows branch 2 times, most recently from 71d740a to fb0deff Compare August 17, 2023 08:01
alexeagle
alexeagle reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels to me like we're defeating the purpose of showing real-life examples if we have a GitHub repo using GitLab CI/CD. Shouldn't we have a project hosted on GitLab for this?

@gregmagolan
Copy link
Member Author

It feels to me like we're defeating the purpose of showing real-life examples if we have a GitHub repo using GitLab CI/CD. Shouldn't we have a project hosted on GitLab for this?

I synced this one to GitLab so we have a demonstration repo that gets some traffic and is more than just a hello world: https://gitlab.com/aspect-build/rules_jest/-/pipelines.

@alexeagle
Copy link
Member

Yeah but the syncing part is pretty weird. Are rules_jest contributors going to have to understand their PRs getting synced and then the status checkmark is over on GitLab?
I just want to explore the possibility whether we have some OSS Bazel project that could sensibly live on GitLab rather than GitHub.

@gregmagolan
Copy link
Member Author

gregmagolan commented Aug 17, 2023 •
edited
Loading

Yeah but the syncing part is pretty weird. Are rules_jest contributors going to have to understand their PRs getting synced and then the status checkmark is over on GitLab? I just want to explore the possibility whether we have some OSS Bazel project that could sensibly live on GitLab rather than GitHub.

I don't expect the GitLab CI checkmark will be load bearing here for contributors. Actually, I should add the buildifier check back in here since the GitLab CI check won't show up here.

A GitLab first project sounds good once we figure one out. In the meantime, I'd like to land this so I have a live example for the GitLab trials starting. We can switch this deployment over to another CI host once we have a GitLab first repo.

@gregmagolan gregmagolan marked this pull request as draft August 17, 2023 21:10
@gregmagolan gregmagolan changed the title chore: add Aspect Workflows CI (on AWS + GitLab) chore: add Aspect Workflows CI (on AWS + Buildkite) Aug 18, 2023
@gregmagolan gregmagolan force-pushed the aspect_workflows branch 5 times, most recently from 1ce6b66 to 2f93cba Compare August 18, 2023 05:07
@gregmagolan gregmagolan marked this pull request as ready for review August 18, 2023 05:08
@gregmagolan gregmagolan enabled auto-merge (squash) August 18, 2023 05:16
alexeagle
alexeagle reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let Derek give the stamp

@gregmagolan gregmagolan merged commit d31aca8 into main Aug 20, 2023
12 checks passed
@gregmagolan gregmagolan deleted the aspect_workflows branch August 20, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle left review comments

@kormide kormide kormide approved these changes

@mattem mattem Awaiting requested review from mattem

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregmagolan @alexeagle @kormide