Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore conflicting symlinks at site-packages root on venv creation #336

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

mattem
Copy link
Collaborator

@mattem mattem commented Apr 29, 2024

Handle conflicting symlinks when creating the venv directory so that the last link wins if the existing link can be removed.
Also bails early with better error message when conflicts that aren't at the root, or caused by namespace packages are found.

Closes #335


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: no
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Handle conflicting symlinks at venv root during venv creation.

Test plan

  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

Force a conflict and observe error message.

@mattem mattem force-pushed the conflicting_symlinks branch from 6480b4f to a03fd83 Compare April 29, 2024 18:22
@mattem mattem requested a review from alexeagle April 29, 2024 18:23
@alexeagle alexeagle merged commit d45e542 into main Apr 29, 2024
14 checks passed
@alexeagle alexeagle deleted the conflicting_symlinks branch April 29, 2024 23:25
@vors
Copy link

vors commented Apr 29, 2024

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: venv symlink creation can run into collisions
3 participants