Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatible types to file generated by __test__.py #441

Merged

Conversation

hofbi
Copy link
Contributor

@hofbi hofbi commented Nov 19, 2024

As suggested in #435 (comment) a backwards compatible (< Python 3.9) type hint.

Regardless of merging this PR or not, the current 1.0.0 release is broken for < Python 3.9. Since Python 3.8 is already EOL, this is in theory valid, but I guess there are still a few people using Python 3.8 because of Ubuntu 20.04.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@hofbi
Copy link
Contributor Author

hofbi commented Nov 19, 2024

When looking for test cases, I found

python_version = "3.8.12"
which seems to test with Python 3.8, hence I would expect that this test should have failed.

@mattem
Copy link
Collaborator

mattem commented Nov 19, 2024

Thanks 🙌
Yeah the tests never ran on #428 as the author hadn't submitted a PR to rules_py before, and I missed clicking the "Approve Workflow Run" to run the tests, and it seems the settings on this repo allows merging with no CI results. If this is green I can merge this and tag a v1.0.1.

@mattem mattem merged commit eb9e0f2 into aspect-build:main Nov 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants