Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Compatibility with symbolic macros #488

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: Compatibility with symbolic macros #488

merged 1 commit into from
Jan 8, 2025

Conversation

dzbarsky
Copy link
Contributor

@dzbarsky dzbarsky commented Dec 23, 2024 •
edited
Loading

Changes are visible to end-users: yes/no

See https://bazel.build/extending/macros#naming, these naming conventions are violated by this legacy macro (and thus by a symbolic macro wrapping this legacy macro)

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@jbedard jbedard merged commit c35d666 into aspect-build:main Jan 8, 2025
12 checks passed
@dzbarsky dzbarsky deleted the zbarsky/macros branch January 11, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @jbedard