Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add --check_direct_dependencies to .bazelrc #625

Merged
merged 1 commit into from
Jun 7, 2024
Merged

chore: add --check_direct_dependencies to .bazelrc #625

merged 1 commit into from
Jun 7, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Jun 7, 2024 •
edited
Loading

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Jun 7, 2024 •
edited
Loading

Test

All tests were cache hits

79 tests (100.0%) were fully cached saving 10s.

Buildifier      Format

@gregmagolan gregmagolan enabled auto-merge (squash) June 7, 2024 16:39
@gregmagolan gregmagolan merged commit 25ce0e9 into main Jun 7, 2024
23 checks passed
@gregmagolan gregmagolan deleted the check_direct_deps branch June 7, 2024 18:49
@alexeagle
Copy link
Member

Note, I just added this to bazel-lib presets, since we think all our rules and customers should have it?

@gregmagolan
Copy link
Member Author

Note, I just added this to bazel-lib presets, since we think all our rules and customers should have it?

We just want this off for rule sets right? Default is warning and is correct for terminal workspaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

@thesayyn thesayyn Awaiting requested review from thesayyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregmagolan @alexeagle @jbedard