Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts_proto_library): expose protoc_gen_options on ts_proto_library #650

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mattem
Copy link
Member

@mattem mattem commented Jul 12, 2024

Exposes a dict for setting options on protoc_gen on the ts_proto_library


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below:

Allow custom options to be set on ts_proto_library for protoc-gen.

Test plan

  • Manual testing; please provide instructions so we can reproduce:

Run locally patched in Silo.

@mattem mattem requested review from alexeagle and jbedard July 12, 2024 19:41
Copy link

aspect-workflows bot commented Jul 12, 2024

Test

All tests were cache hits

81 tests (100.0%) were fully cached saving 12s.


Buildifier      Format

@jbedard
Copy link
Member

jbedard commented Jul 23, 2024

Can we make this an explicit argument in the public macro and document it there?

@jbedard jbedard changed the title feat: expose protoc_gen_options on ts_proto_library feat(ts_proto_library): expose protoc_gen_options on ts_proto_library Jul 23, 2024
@jbedard jbedard requested a review from mrmeku July 23, 2024 21:08
@mattem mattem enabled auto-merge (squash) July 23, 2024 21:14
@mattem mattem merged commit 56f0338 into main Jul 23, 2024
19 checks passed
@mattem mattem deleted the protoc_gen_options branch July 23, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants